Skip to content

[Mistral] Move MistralConverter into integrations/mistral/ package#46603

Open
juliendenize wants to merge 1 commit into
huggingface:mainfrom
juliendenize:mistral/01-package-converter
Open

[Mistral] Move MistralConverter into integrations/mistral/ package#46603
juliendenize wants to merge 1 commit into
huggingface:mainfrom
juliendenize:mistral/01-package-converter

Conversation

@juliendenize

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Move the tekken→HF tokenizer converter into a dedicated, lazily-loaded Mistral integration package.
  • Fix the vocab index offset so special tokens occupy the first ids.
  • Add from_tekken_file(), which pre-computes the vocab and merges in a single pass.
  • Assign special-token ids from their explicit rank, independent of list ordering.
  • Register special tokens as special so they are stripped when decoding with skip_special_tokens=True.
  • Preserve the original tekken metadata so the tokenizer can be re-saved losslessly.

Tested with RUN_SLOW=1 pytest tests/integrations/mistral/test_tokenizer.py → 22 passed (incl. slow tests downloading tekken.json from mistralai/Ministral-3-3B-Instruct-2512 and mistral-common cross-backend equivalence).

Code Agent Policy

The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.

PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.

This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read CONTRIBUTING.md.

  • I confirm that this is not a pure code agent PR.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

tokenizers: @ArthurZucker and @itazap

@juliendenize juliendenize force-pushed the mistral/01-package-converter branch from 000d773 to ca2d153 Compare June 12, 2026 14:10
@juliendenize juliendenize marked this pull request as ready for review June 12, 2026 14:24
@github-actions github-actions Bot requested review from SunMarc and ydshieh June 12, 2026 14:24
@github-actions

Copy link
Copy Markdown
Contributor

CI Dashboard: View test results in Grafana

@SunMarc SunMarc requested review from ArthurZucker and itazap June 15, 2026 15:36
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants